Start MCP Instrumentation Library #3678
Open
+592
−587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Aug 6, 2025
|
|
||
| [project.optional-dependencies] | ||
| instruments = [ | ||
| "mcp >= 0.1.6", |
There was a problem hiding this comment.
Let's not make this mistake again, please. Can you bump this version to a relatively new one?
There was a problem hiding this comment.
No need to apologize, I meant because of Starlette and httpx.
Kludex
reviewed
Aug 6, 2025
pyproject.toml
Outdated
Comment on lines
219
to
220
| "instrumentation-genai/opentelemetry-instrumentation-mcp/tests/**/*.py", | ||
| "instrumentation-genai/opentelemetry-instrumentation-mcp/examples/**/*.py", |
There was a problem hiding this comment.
I'm disappointed this exclude section grew so much and by new projects... It was not supposed to be used by new projects.
I don't think it makes sense to add those 2. Supporting proper type hints from the beginning is easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR begins the basic structure of adding instrumentation to the mcp following the same structure as:
AWS Distro for OpenTelemetry (ADOT) is in process of developing an mcp instrumentation library package and would like to contribute the work. It is currently limited to traces only and doesn't include metrics and log events.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.